Pull Request Explorer

Summary

chore: release v16

Releases version 16 of ERPNext, updating scripts, tests, and configuration to support new features and bug fixes.

Health Assessment

• • Release merged in under 17 hours with minimal review friction, indicating an efficient release process. The large code churn reflects many backported bug fixes, raising the risk profile of the change.

Summary

Fix Gross Profit calculation for rate adjustment debit notes

Corrects gross profit reporting for rate adjustment debit notes, preventing inflated buying amounts and inaccurate profit percentages. Accurate reporting improves financial insights and decision-making for stakeholders.

Health Assessment

• • B
• • a
• • c
• • k
• • p
• • o
• • r
• • t
• •
• • r
• • e
• • s
• • o
• • l
• • v
• • e
• • d
• •
• • q
• • u
• • i
• • c
• • k
• • l
• • y
• •
• • w
• • i
• • t
• • h
• •
• • m
• • i
• • n
• • i
• • m
• • a
• • l
• •
• • c
• • h
• • a
• • n
• • g
• • e
• • s
• •
• • a
• • n
• • d
• •
• • n
• • o
• •
• • r
• • e
• • v
• • i
• • e
• • w
• •
• • f
• • r
• • i
• • c
• • t
• • i
• • o
• • n
• • ,
• •
• • i
• • n
• • d
• • i
• • c
• • a
• • t
• • i
• • n
• • g
• •
• • l
• • o
• • w
• •
• • r
• • i
• • s
• • k
• • .

Summary

Fix Gross Profit calculation for rate adjustment debit notes

Corrects gross profit calculation by setting buying amount to zero for rate adjustment debit notes, ensuring accurate COGS attribution and preventing inflated buying amounts.

Health Assessment

• • Merged within 12 minutes with minimal changes and added tests, indicating a straightforward, low-risk fix.

Summary

Fix Gross Profit calculation for rate adjustment debit notes

This fix corrects gross profit calculations for rate adjustment debit notes, eliminating inflated cost of goods sold and ensuring accurate profitability reporting. It also adjusts quantity aggregation to reflect true sales volumes.

Health Assessment

• • Quick fix with minimal changes and rapid review, indicating low complexity and high confidence in correctness.

Summary

Fix internal transfer purchase receipt valuation

Corrects GL entries for intra‑company purchase receipts, preventing expense leakage and ensuring accurate financial reporting.

Health Assessment

• • The PR was reviewed and merged quickly with minimal changes, indicating a straightforward bug fix with low risk to the system.

Summary

Fix variable for valuation method

Corrects a bug that caused incorrect valuation method retrieval, improving inventory accuracy and financial reporting.

Health Assessment

• • Quick backport resolved a single-line bug with minimal review, indicating efficient process.

Summary

Add quality inspection support for stock entry purposes

Ensures quality inspections are required for all relevant stock entry rows, improving compliance and preventing missing inspections on outgoing items.

Health Assessment

• • The PR underwent multiple review cycles over several days, indicating complex logic changes and thorough validation of quality inspection rules.

Summary

Add permission checks to whitelisted functions

Adds permission checks to sensitive whitelisted functions and hides UI elements for unauthorized users, improving security.

Health Assessment

• • Backport merged within 0.3 hours with minimal changes, indicating low complexity and high confidence in the fix.

Summary

Add permission checks to whitelisted functions

Adds permission checks to sensitive whitelisted functions, preventing unauthorized use and enhancing data security.

Health Assessment

• • Quick backport with minimal changes, no review needed, low risk.

Summary

Refactor bulk_transaction_log existence check to query builder

This refactor moves the bulk transaction log existence check into the query builder, simplifying code and improving query efficiency. Resulting in faster checks and easier maintenance.

Health Assessment

• • Quick refactor with minimal changes, merged within 18 minutes, indicating smooth review and low risk.

Summary

Add DISTINCT row-count and refactor faithfulness rules

Enhances PostgreSQL compatibility guide with new review rules to prevent regressions in DISTINCT queries and refactor conversions.

Health Assessment

• • Quick merge with minimal changes and no review needed, indicating low complexity.

Summary

Fix None args handling in transaction processing

Prevents crashes when transaction processing is called without arguments, improving system stability.

Health Assessment

• • Resolved in a single commit with minimal changes, indicating low complexity.

Summary

Fix variable for valuation method

Corrects a bug that fetched the wrong valuation method, ensuring accurate financial calculations for sales and purchase returns.

Health Assessment

• • Quick backport with minimal changes, merged within minutes, indicating low complexity and high confidence in the fix.

Summary

Refactor bulk_transaction_log existence check

Improves database query efficiency for bulk transaction logs by moving existence checks into the query builder, reducing overhead and simplifying code. This change enhances maintainability and may reduce latency for bulk transaction operations.

Health Assessment

• • Fast cycle time with immediate review and single commit indicates smooth integration.

Summary

Add CI workflow to warmup test data

Ensures the test database is preloaded with data before tests run, improving test reliability and reducing flaky test failures.

Health Assessment

• • Merged within 2.6 hours with only two small files added, indicating a straightforward CI enhancement with minimal risk.

Summary

Fix variable for valuation method fetch

Corrects valuation method lookup, ensuring accurate financial calculations for sales and purchase returns.

Health Assessment

• • Hotfix merged within minutes with minimal changes, indicating low risk and quick resolution.

Summary

Fix MR status to received when per_received is 100

Ensures material request status correctly reflects full receipt, improving inventory accuracy.

Health Assessment

• • Quick fix with minimal changes, fast review and merge.

Summary

Revert removal of unused whitelisted method

Restores a previously removed method to maintain project functionality and prevent potential issues.

Health Assessment

• • Quick revert with minimal changes, fast review, low risk.

Summary

Remove translation for filter in global defaults

Fixes dropdown issue when language is non-English by removing translation for default distance unit, ensuring users see correct options.

Health Assessment

• • Quick fix with minimal changes, no rework, merged within 20 hours.

Summary

Fix sales order per billed on credit note submission

Ensures Sales Order billing status remains accurate after credit note processing, preventing inconsistent per_billed values and maintaining correct order state.

Health Assessment

• • Quick review and single commit indicate a straightforward bug fix with minimal risk.

Summary

Health Assessment

Summary

Fix Asset Depreciation Field Visibility

Ensures users can correctly set depreciation status for manually entered assets, improving financial accuracy.

Health Assessment

• • Merged within 15 minutes with minimal changes and no tests added, indicating a low‑risk, straightforward fix.

Summary

Health Assessment

Summary

Fix stock ledger valuation for returns without bundle

Ensures accurate stock valuation and prevents accounting discrepancies when returning stock that was originally received without a serial/batch bundle.

Health Assessment

• • Quick fix with minimal changes, merged within 1.1 hours, indicating smooth review and low complexity.

Summary

Fix stock ledger valuation for returns without bundle

Corrects stock ledger valuation for return transactions when the original receipt lacks a serial/batch bundle, preventing desynchronization between stock and GL accounts.

Health Assessment

• • Fast turnaround with minimal rework; PR merged within 1.1 hours, indicating a straightforward bug fix.

Summary

Add custom renderer and parser for banking rules

Improves rendering of translated strings and rule evaluation in the banking module, enhancing user experience and accuracy.

Health Assessment

• • Merged within 48 minutes with minimal review, indicating a straightforward bugfix with low complexity.

Summary

Fix quantity update in future stock ledger entries

Ensures accurate inventory levels when documents are cancelled, preventing inventory discrepancies.

Health Assessment

• • Quick backport with minimal changes, merged within minutes, indicating low complexity and risk.

Summary

Fix stock ledger valuation for returns without bundle

Corrects stock ledger valuation for return transactions lacking a serial/batch bundle, preventing inventory misalignment and financial discrepancies.

Health Assessment

• • Quick fix with minimal changes, resolved in a single review cycle, indicating low complexity and risk.

Summary

Health Assessment

Summary

Fix Postgres transaction aborts and division by zero

Ensures database consistency across engines, preventing transaction aborts and division errors, improving reliability for accounting and inventory modules.

Health Assessment

• • Rapid review and merge within 15 hours, minimal code churn, addressing critical database consistency bugs across multiple modules.

Summary

Conditionally show Is Fully Depreciated field

Makes the depreciation status field visible and editable for existing assets when depreciation calculation is off, enabling accurate manual asset management.

Health Assessment

• • Long review cycle and merge time suggest a blocker or low priority; minimal code changes indicate low risk to the system.

Summary

Fix supplier-RFQ portal list query

Corrects two critical defects in the supplier portal RFQ list query, ensuring proper column usage and Postgres compatibility, restoring functionality across MariaDB and Postgres.

Health Assessment

• • The PR involved a single, concise change that addressed two query bugs, was reviewed and merged within 22 hours, indicating a smooth process with minimal risk.

Summary

Fix supplier-RFQ portal list query

The supplier portal RFQ list now correctly retrieves submitted RFQs, ensuring functionality across MariaDB and Postgres. This resolves critical errors that prevented suppliers from viewing their RFQs.

Health Assessment

• • Quick fix resolved critical query errors across both database engines, improving supplier portal reliability.

Summary

Fix MR status stuck when over-receipt

This fix ensures Material Requests correctly transition to 'Received' when all items are received, even if the purchase order was initially undersized, preventing UI deadlock and improving inventory accuracy.

Health Assessment

• • Quick fix with minimal changes, merged within an hour, indicating low complexity and high confidence.

Summary

Sync translations to version-16-hotfix

Automated synchronization of translation files from the main development branch to the hotfix branch, ensuring consistency across languages.

Health Assessment

• • The PR was merged within 18 hours with no review, indicating an automated, low‑complexity process. The large line changes reflect bulk translation updates rather than code logic changes.

Summary

Fix MR status stuck when over-receipt occurs

This patch ensures Material Requests correctly transition to 'Received' when all items are received, even if the Purchase Order was initially undersized, preventing stale open requests and improving inventory accuracy.

Health Assessment

• • Quick fix with minimal changes, merged within 15 hours, indicating low complexity and high confidence in resolution.

Summary

Health Assessment

Summary

Fix project assignment in Purchase Receipt GL entries

Ensures Purchase Receipt GL entries correctly reflect item-level projects, aligning behavior with Purchase Invoices and improving financial reporting accuracy.

Health Assessment

• • Quick, single-file change with minimal impact, merged within hours of opening.

Summary

Fix project propagation in Purchase Receipt GL entries

Ensures Purchase Receipt GL entries correctly use item-level project, aligning behavior with Purchase Invoice and improving accounting accuracy.

Health Assessment

• • Quick fix with minimal changes, merged within the same day, indicating low complexity and high confidence.

Summary

Fix failed invoice handling during import

Ensures import process continues on PostgreSQL even when individual invoices fail, preventing full import abort and maintaining data integrity.

Health Assessment

• • Quick fix with minimal changes, no rework, low risk.

Summary

Fix deterministic tiebreakers for database lookups

This change guarantees consistent financial metrics across database engines, eliminating silent discrepancies that could affect reporting accuracy. It stabilizes key reports like Gross Profit and Asset Location, improving data reliability for stakeholders.

Health Assessment

• • Rapid resolution with minimal changes, no blockers, and immediate review indicates low risk.

Summary

Fix DB savepoint handling for Postgres

Ensures database operations continue after a failed statement in PostgreSQL by wrapping them in savepoints, preventing transaction aborts and maintaining data integrity.

Health Assessment

• • Rapid review and merge indicate a straightforward fix with minimal risk.

Summary

Fix Postgres CI: stop failure handling and remove redundant config

Ensures CI jobs fail on Postgres shutdown errors and removes unnecessary ALTER SYSTEM commands, preventing corrupted data artifacts and improving reliability. This reduces flaky test runs and improves CI stability.

Health Assessment

• • Quick fix with minimal changes, no rework, fast merge, low risk.

Summary

Pull v14 baseline from GitHub release

Fixes intermittent CI failures by downloading baseline from GitHub release, avoiding Cloudflare rate limits. Ensures reliable Patch Test job execution.

Health Assessment

• • Rapid merge with minimal changes; CI job fixed by switching download source.

Summary

Fix stock reservation for production plans

Ensures raw materials already in stock are correctly reserved, preventing duplicate usage across multiple production plans and improving inventory accuracy.

Health Assessment

• • Resolved a critical stock reservation bug with minimal changes and a quick review turnaround, indicating a smooth and low-risk merge process.

Summary

Fix incorrect doctype name for PCV permission check

Corrects permission logic for Process Period Closing Voucher, preventing unauthorized access and ensuring compliance.

Health Assessment

• • Backport resolved in under 5 hours with a single line change, indicating low complexity and minimal review friction.

Summary

Use correct doctype name for PCV perm-check

Fixes incorrect doctype name in process period closing voucher, ensuring proper permission checks.

Health Assessment

• • Backport of a bug fix with minimal changes, merged quickly with no review friction.

Summary

Fix item-level project on Purchase Receipt GL entries

Ensures purchase receipts use the correct project dimension for each item, aligning accounting entries with invoices and improving financial reporting accuracy.

Health Assessment

• • Single commit resolved a subtle accounting mismatch; minimal code changes but review cycle exceeded 72 hours, indicating a slow review process.

Summary

Health Assessment

Summary

Fix negative stock issue

Corrects a bug that allowed cancellation of purchase receipts with negative stock, ensuring inventory integrity.

Health Assessment

• • Rapid resolution with minimal changes; quick review and merge indicates low complexity.