Pull Request Explorer

Summary

Fix invalid filter on item group

Corrects a filtering issue that prevented item groups from being displayed properly, improving data accuracy for inventory management.

Health Assessment

• • Merged immediately after commit, indicating a straightforward change with minimal risk.

Summary

Refactor supplier scorecard variable to use query builder

Replace raw SQL with query builder to ensure PostgreSQL compatibility, improving database portability.

Health Assessment

• • Quick review and merge, minimal changes, low risk.

Summary

Refactor RFQ status update to query builder

Improves PostgreSQL compatibility by replacing raw SQL with query builder, enhancing maintainability and reducing database-specific issues.

Health Assessment

• • Quick review and merge within 3 hours, minimal changes, low complexity.

Summary

Replace SQL with ORM for Supplier Scorecard

This refactor replaces raw SQL with the Frappe ORM, ensuring PostgreSQL compatibility and simplifying future maintenance. It reduces database-specific code and aligns the module with the framework's best practices.

Health Assessment

• • Quick refactor with minimal changes, merged within hours, indicating low complexity and high confidence.

Summary

Replace SQL with ORM for Supplier Quotation

Ensures PostgreSQL compatibility by switching from raw SQL to the Frappe ORM, improving database portability and maintainability. This change reduces potential SQL injection risks and aligns with best practices.

Health Assessment

• • The PR was merged quickly with minimal changes, indicating a straightforward refactor with low risk.

Summary

Refactor request_for_quotation to use query builder

Replace raw SQL with query builder for PostgreSQL compatibility, improving database portability. This change enhances cross-database support and reduces maintenance.

Health Assessment

• • Quick refactor with minimal changes, merged within hours, indicating smooth review and low complexity.

Summary

Refactor territory sales report to use ORM

Replaces raw SQL with Frappe ORM for PostgreSQL compatibility, improving maintainability and database portability.

Health Assessment

• • Quick review cycle with AI assistance, minimal code changes, low risk to production

Summary

Replace SQL with Query Builder in Supplier Quotation

Ensures PostgreSQL compatibility by refactoring raw SQL to query builder, improving maintainability and database portability.

Health Assessment

• • Single commit, minimal changes, quick review, low risk

Summary

Replace SQL with ORM for Supplier Scorecard

This refactor replaces raw SQL queries with ORM-based queries to ensure compatibility with PostgreSQL, improving database portability and maintainability.

Health Assessment

• • Quick review and merge within 3.4 hours indicates a smooth process with minimal friction.

Summary

Replace SQL with Query Builder for PostgreSQL

This refactor replaces raw SQL with a query builder, ensuring compatibility with PostgreSQL and improving maintainability of supplier scorecard logic. It reduces database-specific dependencies and future‑proofs the feature.

Health Assessment

• • Fast cycle time and minimal review indicate a straightforward refactor with low risk.

Summary

Replace SQL with Query Builder for PostgreSQL

This refactor replaces raw SQL with a query builder, ensuring compatibility with PostgreSQL and improving database portability for ERPNext users. It reduces potential database errors and supports multi-database deployments.

Health Assessment

• • Quick refactor with minimal scope and fast merge indicates low risk and efficient review.

Summary

Replace SQL with Query Builder for Supplier Scorecard

The refactor replaces raw SQL with a query builder, ensuring compatibility with PostgreSQL. This improves database portability and reduces potential errors in supplier scorecard calculations.

Health Assessment

• • Merged within 3.4 hours with minimal changes, indicating a low‑complexity refactor and high confidence in the update.

Summary

Replace SQL with query builder for PostgreSQL

Ensures compatibility with PostgreSQL by refactoring raw SQL to a query builder, improving maintainability and database portability.

Health Assessment

• • Fast review and merge with minimal changes, indicating low complexity and risk.

Summary

Fix slow query in accounts module

Improves performance of account queries, reducing load times for users.

Health Assessment

• • Quick backport with minimal changes, merged within minutes.

Summary

Add pending quantity handling to job card

Introduces a Pending Qty field to job cards, preventing incorrect process loss calculations and improving job completion accuracy for users.

Health Assessment

• • The PR received multiple AI‑assisted review comments and required several iterations, indicating a complex change that was ultimately merged after thorough review.

Summary

Migrate item_query to Query Builder

Refactors database query logic to use Frappe Query Builder, improving PostgreSQL compatibility and reducing raw SQL usage.

Health Assessment

• • PR required extensive back‑and‑forth with AI review, leading to multiple commits over 10 days, indicating a complex refactor with significant review friction.

Summary

Health Assessment

Summary

Fix stock UOM quantity for purchase documents

Corrects unit-of-measure quantity handling in purchase documents, ensuring accurate inventory tracking.

Health Assessment

• • Backport applied quickly with minimal changes, no review required.

Summary

Fix stock UOM quantity for purchase documents

Corrects unit-of-measure quantity handling in purchase documents, ensuring accurate inventory tracking.

Health Assessment

• • Quick backport with minimal changes, merged within 0.3 hours, indicating low complexity and risk.

Summary

Improve cancellation performance with Immutable Ledger

This change removes unnecessary database updates during cancellation when Immutable Ledger is enabled, cutting cancellation time from minutes to seconds and improving overall system performance.

Health Assessment

• • Fast cycle time and minimal rework indicate a straightforward performance fix with low risk.

Summary

Improve cancellation performance with Immutable Ledger

This PR removes unnecessary database updates during cancellation when Immutable Ledger is enabled, cutting cancellation time from minutes to seconds and improving overall system performance.

Health Assessment

• • Quick merge with minimal changes and no review comments indicates low risk and high confidence in performance improvement.

Summary

Remove unused forecast fields from sales forecast

This PR cleans up the sales forecast data model by removing unused forecast_qty and adjust_qty fields, reducing clutter and potential confusion for users.

Health Assessment

• • Backport of a small cleanup change, merged quickly with minimal review.

Summary

Fix stock UOM quantity editing for purchases

Corrects quantity handling for stock units of measure in purchase documents, ensuring accurate inventory tracking and preventing potential stock miscalculations.

Health Assessment

• • Quick fix with minimal changes, reviewed and merged within a day, indicating low complexity and high confidence in the patch.

Summary

Improve cancellation performance with Immutable Ledger

Eliminates unnecessary database updates during cancellation, cutting wait times by ~97% and enhancing user experience.

Health Assessment

• • The PR resolved a critical performance regression in Immutable Ledger cancellation, receiving rapid AI-assisted review and multiple iterations to ensure correctness and speed.

Summary

Refactor tax template query builder with hierarchy

Improves tax rule accuracy by using secure query builder and adding hierarchical supplier group matching, ensuring correct tax application for standard and webshop transactions.

Health Assessment

• • Fast cycle time and minimal rework indicate a smooth review process; AI assistance likely accelerated implementation.

Summary

Migrate custom fields from fixtures to install

Remove fixture files and programmatically create custom fields during installation, ensuring existing installations are updated via migration patch. This streamlines deployment and reduces manual configuration.

Health Assessment

• • Backport completed quickly with minimal changes and resolved conflicts promptly, indicating a low-risk maintenance update.

Summary

Refactor tax template to query builder

Replaces raw SQL with parameterized query builder, adds hierarchical supplier group matching, and ensures shopping cart rules are applied correctly, improving security and correctness.

Health Assessment

• • Fast merge with minimal review, indicating a straightforward refactor with clear AI assistance.

Summary

Correct remarks for foreign currency payment entries

Ensures accurate remarks for foreign currency payment entries, improving financial reporting accuracy.

Health Assessment

• • Backport performed automatically with minimal changes, no review required.

Summary

Correct remarks for foreign currency payment entries

Ensures accurate remarks for foreign currency payments, improving financial reporting and compliance.

Health Assessment

• • Quick, single-file change with minimal impact, merged within hours.

Summary

Correct description for Is Rate Adjustment Entry checkbox

Fixes the wording of a checkbox in the sales invoice form, improving user clarity.

Health Assessment

• • Backport merged quickly with minimal changes, indicating low complexity and high confidence.

Summary

Add default_letter_head_report field to Company doctype

Adds a company-level default letter head for reports, enabling consistent branding across documents.

Health Assessment

• • PR had a long cycle time with no review, but small scope; likely low impact but delayed delivery.

Summary

Correct description for Rate Adjustment checkbox

Fixes incorrect description for the Rate Adjustment Entry checkbox in sales invoices, improving clarity for users.

Health Assessment

• • Merged within 30 minutes, indicating a straightforward, low‑risk change.
• • Minimal code churn (4 lines) and no complex logic, suggesting low review friction.

Summary

Fix net_purchase_amount reset for Composite Asset

Corrects a bug that incorrectly reset net_purchase_amount for Composite Assets when already set, improving financial accuracy.

Health Assessment

• • Quick backport fix with minimal changes, merged within minutes.

Summary

Prevent resetting net_purchase_amount for Composite Assets

Ensures accurate financial calculations for composite assets, preventing data loss.

Health Assessment

• • Quick fix merged within minutes, minimal changes, low risk.

Summary

Refactor tax template query builder with hierarchy

Enables hierarchical supplier group matching for tax rules, improving accuracy. Switches to parameterized query builder, enhancing security and maintainability.

Health Assessment

• • Rapid iteration with AI assistance led to quick resolution and minimal review friction.

Summary

Remove redundant code in stock ledger

Eliminates unnecessary logic in the stock ledger, improving maintainability.

Health Assessment

• • Backport merged quickly with minimal changes, indicating low complexity and risk.

Summary

Fix operation cost calculation backport

Corrects cost calculation for stock entries, preventing incorrect cost deductions and handling overproduction scenarios, improving financial accuracy.

Health Assessment

• • Backport completed quickly with minimal changes, indicating a straightforward bug fix with low risk to production.

Summary

Remove redundant code in stock ledger

Eliminates unnecessary logic in the stock ledger, improving maintainability and reducing potential bugs.

Health Assessment

• • Backport merged quickly with minimal changes, indicating low complexity and risk.

Summary

Health Assessment

Summary

Remove unused forecast_qty and adjust_qty fields

Eliminates unused fields from sales forecast to reduce clutter and potential confusion.

Health Assessment

• • Quick cleanup with minimal changes, merged within 2 hours, indicating smooth review and low risk.

Summary

Fix incoming rate for legacy serial numbers

Adds a setting to correctly fetch incoming rates for legacy serial numbers, preventing incorrect valuation during stock reposting.

Health Assessment

• • Long cycle time due to conflict resolution; small scope bugfix; minimal risk to production

Summary

Fix consumed operation cost calculation

Corrects cost calculation when adding additional costs in stock entry, preventing incorrect subtraction of operation costs and handling over production cases.

Health Assessment

• • Long review cycle with multiple reverts and coderabbit AI review indicates complex changes and potential integration issues.

Summary

Fix pricing rule using wrong value

Corrected a bug where discounts were applied twice due to mixed_conditions, improving pricing accuracy and preventing revenue loss.

Health Assessment

• • The PR addressed a double‑discount bug with minimal code changes, but the long cycle time suggests potential delays in the review process.

Summary

Remove redundant stock quantity recalculation

Streamlines stock reconciliation by eliminating unnecessary internal calculation, improving performance and reducing complexity.

Health Assessment

• • Merged within 18 minutes with a single commit, indicating a straightforward change with minimal review friction.

Summary

Fix status display for settled credit notes

Corrects the status indicator for sales invoices settled by credit notes, ensuring users see a green 'Settled with Credit Note' label when outstanding amounts are zero. This improves clarity for receivables management.

Health Assessment

• • The PR took over two weeks to merge with minimal changes, indicating a slow review process or low priority.

Summary

Fix weight setting in update items

Corrects weight calculation during item updates, ensuring accurate inventory management.

Health Assessment

• • Quick review and merge within 8 hours, minimal changes, low risk.

Summary

Health Assessment

Summary

Enable drop-ship Purchase Orders without Sales Order

Allows users to create drop-ship purchase orders without requiring a linked sales order, streamlining direct supplier-to-customer workflows and reducing validation errors.

Health Assessment

• • Quick review (0.1h) but long cycle time (163h) due to integration into develop; overall process was efficient but delayed by branch merge timing.

Summary

Migrate custom fields from JSON to install

This PR removes JSON fixture files for address and contact custom fields and replaces them with programmatic creation during installation, ensuring new installations and migrations create the fields correctly.

Health Assessment

• • Fast merge with minimal changes, no review comments, indicating straightforward maintenance.

Summary

Fix item price with party condition

Corrects pricing logic for items with party conditions, ensuring accurate stock valuations.

Health Assessment

• • Backport resolved a critical pricing bug quickly with minimal code changes.